b82ed3f167
Fix potential blocking operation on OrderByTotalScoreAsync()
...
In reality this wouldn't be a long process, but the blocking is really
noticeable if you add a Task.Delay(1000) in GetTotalScoreAsync().
2021-10-08 14:23:54 +09:00
da96cc73d8
Fix dual specification of SuspensionHandler and move fields around slightly
2021-10-07 23:40:47 +09:00
9bf29503fb
Rename remaining usage
2021-10-07 20:57:14 +09:00
310d7965b6
Merge branch 'master' into more-filter-effects
2021-10-07 20:52:38 +09:00
f8e50731b7
Merge pull request #14991 from peppy/intro-tests-no-menu-load
...
Allow intro screens to be created without loading a `MainMenu`
2021-10-07 20:48:54 +09:00
ef64c64f0b
Merge branch 'master' into popup-filter-effect
2021-10-07 18:56:07 +09:00
e578046b20
Rename Filter -> AudioFilter
2021-10-07 18:50:08 +09:00
0348c6c7e5
Apply some renaming and code quality fixes
2021-10-07 18:49:22 +09:00
bece807857
Merge pull request #14980 from peppy/difficulty-move-to-beatmap
...
Copy `BaseDifficulty` to `Beatmap<T>` and move the majority of write operations across
2021-10-07 18:43:44 +09:00
f98dd1b811
Merge branch 'master' into popup-filter-effect
2021-10-07 18:40:21 +09:00
f6458aa26d
Add filter effect to collection management dialog
2021-10-07 17:56:11 +09:00
cc209f0f2d
Add filter effect to fail sequence
2021-10-07 17:55:30 +09:00
5c48340520
Add filter effect to beatmap loading
2021-10-07 17:55:21 +09:00
ee66414e4f
Move difficulty copy inside context retrieval
2021-10-07 17:49:13 +09:00
0e0779e45b
Merge pull request #14988 from peppy/remove-gameplay-mod-bindable-storage
...
Remove local overridden storage of `Mods` in `Player`
2021-10-07 17:36:23 +09:00
d3efec3c04
Remove unnecessary clone operations
2021-10-07 17:22:10 +09:00
7dd7d35fc8
Remove unnecessary difficulty copy operation
2021-10-07 17:19:34 +09:00
0df409c050
Move difficulty copy to BeatmapModelManager.Save
2021-10-07 17:16:45 +09:00
d50443fdf2
Merge branch 'master' into difficulty-move-to-beatmap
2021-10-07 16:50:10 +09:00
d0001f760d
Group applicable comment above new addition
2021-10-07 16:50:05 +09:00
f88d898960
Allow intro screens to be created without loading a MainMenu
2021-10-07 16:38:22 +09:00
290c9755e2
Always use circles intro for OsuGame tests
...
The triangles intro tracks video time, which is not adjusted based on
the game's playback rate (ie. it runs in realtime even for headless
tests).
Maybe we want to make the triangles video adjust its rate along with
tests?
2021-10-07 15:55:29 +09:00
a57b080f10
Avoid showing the disclaimer in game tests
...
No real performance gain, but this is handy to bypass when actually
using one of these tests to test something.
2021-10-07 15:55:15 +09:00
5f129ae33c
Remove local overridden storage of Mods in Player
...
Not required and only causing headaches. Accessing mods should now be
done via `GameplayState`.
Closes #14912 .
2021-10-07 14:53:39 +09:00
9705c7b546
Use cloned mods in one more place
2021-10-06 21:30:30 +09:00
433e7cd403
Fix rate mods not working if pp counter is displayed
2021-10-06 21:26:30 +09:00
99fb86878e
Only detach filter on disposal if attached
2021-10-06 18:31:56 +09:00
bd0c986144
Add asserts to ensure correct state when attaching/detaching the filter
2021-10-06 17:34:24 +09:00
4ca97bc60a
Merge branch 'master' into difficulty-move-to-beatmap
2021-10-06 16:14:21 +09:00
3803f2f462
Fix leaderboard potentially displaying the wrong scores
...
Closes #14762 .
This class is ugly. I think the whole process should be clened up once
we have correctly-scheduled `SynchronizationContext`s. There's not much
saving it as long as all these interdispersed `Schedule`s around
required.
2021-10-06 16:07:29 +09:00
222997f2b9
Copy difficulty settings back out to BeatmapInfo on editor changes
2021-10-06 15:19:26 +09:00
0ab8dcc2a0
Fix taiko weird difficulty multiplier failing on double convert
2021-10-06 15:18:06 +09:00
b339c149d8
Copy BaseDifficulty to Beatmap<T> and move all write operations across
2021-10-06 15:10:45 +09:00
e6aa05a4a4
Merge pull request #14978 from peppy/fix-editor-file-selector-textbox-drags
...
Fix dragging on an editor file selection text box causing repeated popover display
2021-10-06 13:52:08 +09:00
80c8612630
Merge pull request #14977 from peppy/fix-working-beatmap-cache-invalidation
...
Fix changes not being reflected immediately after exiting the editor
2021-10-06 13:51:21 +09:00
d9849bcf49
Fix dragging on an editor file selection text box causing repeated popover display
...
Local fix and no tests as this is a pretty weird usage of `TextBox`.
We'll probably want to change it to not use a textbox eventually.
Closes #14969 .
2021-10-06 13:15:05 +09:00
90fdaf18c0
Fix PushAndConfirm potentially failing if new screen quickly pushes a child screen
2021-10-06 12:55:04 +09:00
8ffaa491e7
Fix BeatmapModelManager not receiving WorkingBeatmapCache
2021-10-06 12:55:04 +09:00
007b33cd88
Add missing methods to interfaces
2021-10-06 12:55:04 +09:00
ffbb7a9b1a
Remove incorrect csproj change
...
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me >
2021-10-06 12:22:32 +09:00
e837a3511d
Merge branch 'master' into beatmap-difficulty-more-interface-usage
2021-10-06 12:18:51 +09:00
266e62794e
Tweak cutoff effect for new Q value
2021-10-06 11:52:05 +09:00
4bbff2ebf7
Merge branch 'master' into new-interfaces
2021-10-06 11:38:17 +09:00
df182ba92b
Set fQ to recommended value from BASS developer to prevent filter calculations from overflowing when approaching nyquist
2021-10-06 11:29:03 +09:00
9491e5a547
Merge pull request #14954 from peppy/rename-result-response
...
Rename `APIRequest.Result` to `Response`
2021-10-06 10:52:33 +09:00
007e5f174c
Merge pull request #14959 from peppy/add-screen-test-debug
...
Add various logging output in an atttempt to figure multiplayer test failure
2021-10-06 10:11:50 +09:00
4f59fc15a5
Mark BeatmapSet as nullable for the time being
2021-10-06 05:54:37 +09:00
4d5696959b
Remove unnecessary access modifier in interface
...
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me >
2021-10-06 05:52:28 +09:00
1f6a31355c
Remove unused using statement
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com >
2021-10-06 05:30:49 +09:00
5a4474e1b2
Fix incorrect DI retrieval in ReplayDownloadButton
2021-10-06 05:29:00 +09:00
