69803105ef
Fix volume meter requesting focus for any action
2021-07-04 17:19:44 +02:00
5e148b273e
Merge branch 'master' into fix-initial-volume-display-when-zero
2021-07-04 16:16:01 +02:00
14a861003a
Fix code quality errors
2021-07-04 16:06:28 +02:00
50c9e17e52
Return focus when using UP/DOWN on unfocused meter
2021-07-04 15:42:26 +02:00
d0707079b1
Remove unused method
2021-07-04 15:35:51 +02:00
e151c7ffd0
Let VolumeMeter request focus instead of taking it
2021-07-04 15:35:04 +02:00
c143a50b73
Merge branch 'master' into fix-zero-hit-score-submit
2021-07-04 15:31:38 +02:00
d1553f0864
Implement ability to switch between volume meters
2021-07-04 14:47:07 +02:00
3291f15dcc
Mention GetForWrite() as another alternative to Context accesses
2021-07-04 12:08:15 +02:00
b89521314f
Mention alternatives to Context when not on update thread in xmldoc
2021-07-04 12:07:34 +02:00
3ec7dc3bb9
Update tests in line with thread safety check
2021-07-04 17:59:39 +09:00
7a710ceffe
Check count as well (statistics can be populated with zero counts)
2021-07-04 16:41:09 +09:00
567e9f33a9
Fix thread safety of realm Refresh operation
...
Due to the lack of locking, there was a chance the the update thread
`context` was retrieved just before the `flushContexts` call, followed
by `.Refresh()` being run while the blocking behaviour was invoked.
This can be seen in test failures such as
https://ci.appveyor.com/project/peppy/osu/builds/39859786/tests .
As an aside, I tried multiple different methods to avoid `lock()` on the
update thread but they felt flaky. The overhead of lock when there's no
contention is reportedly around 30-50ns, so likely not of concern. We
can address it at a later point if it becomes one.
2021-07-04 16:24:43 +09:00
ef82528309
Don't attempt to submit score when nothing has been hit
2021-07-04 15:16:18 +09:00
149a200f34
Fix volume metre not correctly showing volume when initially zero
...
Closes https://github.com/ppy/osu/issues/13761 .
2021-07-04 14:56:17 +09:00
ec71deec51
Remove some mentions of "lazer"
...
I am aware there are more throughout the codebase but intentionally left
the remaining mentioned for one reason or another. The intention here is
to mainly change user-facing versioning to change the positioning of the
"lazer" term (to be where we would expect "cuttingedge" or "beta" to
be).
2021-07-04 12:41:27 +09:00
12371f7424
Fix playlist item displays as empty string if no unicode title is present
2021-07-04 08:09:38 +08:00
8a23dfa6f5
Fix optimised import path buffering events without flush
2021-07-03 17:58:12 +02:00
fbe3b447e5
Merge branch 'master' into linkify-metadata
2021-07-03 15:51:08 +02:00
6fb8ed4d07
Trim no longer used constant
2021-07-03 15:47:47 +02:00
0be75cc4ed
Fix incorrect base call causing import optimisation to not work
2021-07-03 22:35:46 +09:00
7dae93ad66
Remove unused using directives
2021-07-03 15:23:26 +02:00
16d08df5e2
Remove mention of direct from xmldoc
2021-07-03 15:22:03 +02:00
83578e7c9d
Hold a bound copy reference instead
2021-07-02 23:24:51 +03:00
612ed6353c
Resolve RestoreDefaultValueButton issue by internal management
2021-07-02 22:30:26 +03:00
2b366e04fd
Revert "Fix RestoreDefaultValueButton not behaving correctly on number types"
...
This reverts commit bc0ab7dd4f
2021-07-02 21:06:57 +03:00
ace57a9ee9
Merge pull request #13727 from peppy/update-disclaimer
...
Update disclaimer
2021-07-02 21:08:43 +09:00
5a7706edee
Merge pull request #13726 from nekodex/notch-tick-sfx
...
Add audio feedback for changing volume
2021-07-02 21:08:31 +09:00
6e31c781bb
Merge pull request #13382 from ribbanya/clamp-skin-scale
...
Fix skin elements flipping when scaled below zero
2021-07-02 20:50:47 +09:00
4d85df6bbc
Merge branch 'master' into notch-tick-sfx
2021-07-02 20:38:30 +09:00
66240d582f
Merge branch 'master' into consume-bindable-current-factory
2021-07-02 20:28:57 +09:00
b0f257fa04
Merge pull request #13685 from gagahpangeran/wiki-image-block
...
Fix image overflow in wiki overlay
2021-07-02 20:21:20 +09:00
8847915c6a
Update framework
2021-07-02 18:51:14 +09:00
9eb6ae4d45
Merge pull request #13721 from peppy/submit-on-player-exit
...
Submit scores on player exit
2021-07-02 18:25:26 +09:00
4e52aee5a0
Merge branch 'master' into wiki-image-block
2021-07-02 18:19:46 +09:00
f37e5bdab8
Merge pull request #13742 from aitani9/skin-editor-flipping-reflect
...
Make flipping in the skin editor reflect across the axes of the selection box
2021-07-02 18:19:04 +09:00
211c248692
Merge pull request #13744 from peppy/fix-async-void-calls
...
Fix some incorrectly invoked `async` calls
2021-07-02 18:10:30 +09:00
362816492f
Move to more friendly namespace
2021-07-02 18:09:16 +09:00
1bbf578dfe
Merge pull request #13714 from bdach/colour-picker
...
Add osu!-styled colour picker control
2021-07-02 18:05:19 +09:00
eacf867073
Move shared types into their own classes
2021-07-02 18:05:00 +09:00
ecb4982281
Add missing blank lines
2021-07-02 17:51:54 +09:00
6a0c5b54c3
Fix obsolete message in Mod.Ranked
2021-07-02 15:55:25 +08:00
35f7966922
Merge conditionals in line with other case of same logic
2021-07-02 15:55:36 +09:00
63d2ac66d2
Fix one more instance of incorrect playback/frequency set order
2021-07-02 15:52:20 +09:00
910fe3e9f8
Center pitch randomisation around base pitch
2021-07-02 15:51:23 +09:00
bd6664d541
Add note about intentional downward pitch, against expectations
2021-07-02 15:48:16 +09:00
13254d51fc
Remove usage of bool for initial playback
...
Also refactors the whole method to generally clean things up. One more
important fix is setting the frequency on the channel before starting
playback, so avoid the frequency potentially being adjusted after the
playback is already started.
2021-07-02 15:48:13 +09:00
69b1347730
Tidy up weird bind logic
2021-07-02 15:29:51 +09:00
9814c24741
Merge branch 'master' into notch-tick-sfx
2021-07-02 15:27:28 +09:00
f2d9d78455
Fix some incorrectly invoked async calls
2021-07-02 14:43:48 +09:00
